Update azure-healthinsights-radiologyinsights SDK from local TypeSpec #41951
+476
−23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Updated SDK using local TypeSpec spec from C:\Users\caperal\repos\azure-rest-api-specs\specification\ai\HealthInsights\HealthInsights.RadiologyInsights - Added new custom inference functionality with begin_custom_inference method - Fixed import-error pylint warnings for collections.abc.MutableMapping imports - Fixed no-value-for-parameter pylint warning in model_base.py - Updated client operations mixin class names to follow new naming convention - Fixed setup.py package folder path resolution - All static validation (Pylint, MyPy, Pyright, Sphinx) now passes successfully touch a different file harmlessly
There was a problem hiding this comment.
Pull Request Overview
This PR updates the azure-healthinsights-radiologyinsights SDK generated from a local TypeSpec, introducing a new custom inference operation and adjusting package structure and APIView mappings.
- Refactor setup.py to derive the package folder path from
PACKAGE_NAMESPACE. - Add
build_radiology_insights_custom_inference_requestand corresponding custom inference methods to both sync and async operation mixins. - Rename the operations mixin to a private
_RadiologyInsightsClientOperationsMixin, update client classes to subclass it, and add new APIView entries forbegin_custom_inference.
Reviewed Changes
Copilot reviewed 9 out of 10 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| sdk/healthinsights/azure-healthinsights-radiologyinsights/setup.py | Use PACKAGE_NAMESPACE to build package_folder_path. |
| sdk/healthinsights/.../aio/_operations/_operations.py | Add custom inference request builder, methods, and rename mixin. |
| sdk/healthinsights/.../aio/_operations/init.py | Remove public export of the old mixin. |
| sdk/healthinsights/.../aio/_client.py | Update client to subclass the private mixin. |
| sdk/healthinsights/.../_utils/model_base.py | Disable pylint error for super().__new__. |
| sdk/healthinsights/.../_operations/_operations.py | Add sync custom inference builder, methods, and rename mixin. |
| sdk/healthinsights/.../_operations/init.py | Remove public export of the old mixin. |
| sdk/healthinsights/.../_client.py | Update client to subclass the private mixin. |
| sdk/healthinsights/azure-healthinsights-radiologyinsights/apiview-properties.json | Add APIView entries for begin_custom_inference. |
Comments suppressed due to low confidence (3)
sdk/healthinsights/azure-healthinsights-radiologyinsights/azure/healthinsights/radiologyinsights/aio/_client.py:20
- [nitpick] Renaming the operations mixin to a private class (
_RadiologyInsightsClientOperationsMixin) and using it in a public client can confuse consumers. Consider keeping a public mixin name or documenting the change to avoid breaking downstream code.
from ._operations._operations import _RadiologyInsightsClientOperationsMixin
sdk/healthinsights/azure-healthinsights-radiologyinsights/azure/healthinsights/radiologyinsights/aio/_operations/_operations.py:297
- New custom inference logic has been introduced but there are no corresponding tests. Please add unit or integration tests for
_custom_inference_initialandbegin_custom_inferenceto ensure proper coverage.
async def _custom_inference_initial(
sdk/healthinsights/azure-healthinsights-radiologyinsights/azure/healthinsights/radiologyinsights/aio/_operations/_operations.py:353
- The exceptions
StreamConsumedErrorandStreamClosedErrorare caught but not imported, which will cause aNameError. Please import them from the appropriate module, for examplefrom azure.core.exceptions import StreamConsumedError, StreamClosedError.
except (StreamConsumedError, StreamClosedError):
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Debugging a possible issue with APIView. Does this properly generate a new APIView entry?